Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin vagrant to older version to avoid known issue 13527 #11226

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

Latest version of vagrant suffers from hashicorp/vagrant#13527, this is affecting all our E2E tests. Pin to 2.4.1 for now.

Types of Changes

CI

Verification

CI Green

Linked Issues

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner November 5, 2024 00:04
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.95%. Comparing base (242239e) to head (f0062d4).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (242239e) and HEAD (f0062d4). Click for more details.

HEAD has 13 uploads less than BASE
Flag BASE (242239e) HEAD (f0062d4)
unittests 1 0
inttests 11 0
e2etests 7 6
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #11226       +/-   ##
===========================================
- Coverage   46.94%   33.95%   -13.00%     
===========================================
  Files         179      162       -17     
  Lines       18569    17979      -590     
===========================================
- Hits         8718     6105     -2613     
- Misses       8491    10834     +2343     
+ Partials     1360     1040      -320     
Flag Coverage Δ
e2etests 33.95% <ø> (-8.15%) ⬇️
inttests ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 8ea6154 into k3s-io:master Nov 5, 2024
17 checks passed
@dereknola dereknola deleted the vagrant_pin branch November 14, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants