Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set kine EmulatedETCDVersion from embedded etcd version #11221

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Nov 4, 2024

Proposed Changes

Set kine EmulatedETCDVersion from embedded etcd version

Fixes issue where kine's reported etcd version was left unset.

Types of Changes

bugfix

Verification

See linked issue for log messages to check

Testing

Linked Issues

User-Facing Change


Further Comments

@brandond brandond requested a review from a team as a code owner November 4, 2024 21:50
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.43%. Comparing base (242239e) to head (862dd48).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11221      +/-   ##
==========================================
- Coverage   46.94%   42.43%   -4.51%     
==========================================
  Files         179      179              
  Lines       18569    18570       +1     
==========================================
- Hits         8718     7881     -837     
- Misses       8491     9480     +989     
+ Partials     1360     1209     -151     
Flag Coverage Δ
e2etests 34.22% <100.00%> (-7.88%) ⬇️
inttests 34.70% <100.00%> (+0.03%) ⬆️
unittests 13.60% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants