Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.28] Fix hosts.toml header var #10874

Merged

Conversation

brandond
Copy link
Member

Proposed Changes

Resolves issue from 270f85e that prevented old hosts.toml files from being cleaned up.

Types of Changes

bugfix

Verification

See linked isse

Testing

Linked Issues

User-Facing Change


Further Comments

Resolves issue from 270f85e that prevented old hosts.toml files from being cleaned up.

Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond requested a review from a team as a code owner September 10, 2024 19:16
@brandond brandond changed the title Fix hosts.toml header var [release-1.28] Fix hosts.toml header var Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.62%. Comparing base (bdebbd3) to head (12f664d).
Report is 1 commits behind head on release-1.28.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28   #10874      +/-   ##
================================================
- Coverage         40.44%   35.62%   -4.83%     
================================================
  Files               179      162      -17     
  Lines             18567    14269    -4298     
================================================
- Hits               7510     5083    -2427     
+ Misses             9778     8186    -1592     
+ Partials           1279     1000     -279     
Flag Coverage Δ
e2etests 35.62% <ø> (-9.69%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit d5b7bac into k3s-io:release-1.28 Sep 10, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants