Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.29] Testing And Secrets-Encryption Backports for 2024-09 #10803

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Sep 3, 2024

Proposed Changes

Contains several (mostly E2E testing) backport

Types of Changes

Testing Improvements

Verification

Testing

All changes are covered by testing

Linked Issues

#10638

User-Facing Change

Update to newer OS images for install testing
Fix caching name for e2e vagrant box
Fix deploy latest commit on E2E tests
Remove secrets encryption controller #10612
DRY E2E Upgrade test setup
Cover edge case when on new minor release for E2E upgrade test

Further Comments

@dereknola dereknola requested a review from a team as a code owner September 3, 2024 21:59
dereknola and others added 7 commits September 6, 2024 10:29
* Update to newer OS images for install testing
* Update vagrant images used for E2E

Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: ShylajaDevadiga <[email protected]>
Co-authored-by: ShylajaDevadiga <[email protected]>
* Remove secrets encryption controller

Signed-off-by: Derek Nola <[email protected]>
@dereknola dereknola merged commit 17201d4 into k3s-io:release-1.29 Sep 6, 2024
29 checks passed
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 79 lines in your changes missing coverage. Please review.

Project coverage is 43.70%. Comparing base (9973e7a) to head (68ed762).
Report is 18 commits behind head on release-1.29.

Files with missing lines Patch % Lines
pkg/server/secrets-encrypt.go 0.00% 75 Missing ⚠️
pkg/secretsencrypt/config.go 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (9973e7a) and HEAD (68ed762). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9973e7a) HEAD (68ed762)
e2etests 7 6
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.29   #10803      +/-   ##
================================================
- Coverage         49.71%   43.70%   -6.02%     
================================================
  Files               179      178       -1     
  Lines             14976    14924      -52     
================================================
- Hits               7446     6523     -923     
- Misses             6167     7203    +1036     
+ Partials           1363     1198     -165     
Flag Coverage Δ
e2etests 36.51% <0.00%> (-9.96%) ⬇️
inttests 36.83% <0.00%> (+0.17%) ⬆️
unittests 13.43% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola deleted the test_bp_sept_129 branch September 12, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants