-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add confirmation prompt for k3s-killall.sh
and k3s-uninstall.sh
#10585
Comments
This repository uses a bot to automatically label issues which have not had any activity (commit/comment/label) for 45 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the bot can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the bot will automatically close the issue in 14 days. Thank you for your contributions. |
+1 |
This repository uses a bot to automatically label issues which have not had any activity (commit/comment/label) for 45 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the bot can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the bot will automatically close the issue in 14 days. Thank you for your contributions. |
Is your feature request related to a problem? Please describe.
These two scripts have no confirmation and it is like having
rm -rf /*
over the user's fingertips.Describe the solution you'd like
Add an overridable prompt which will prevent most human errors and allow headless operation to run smoothly by passing an environment variable.
Describe alternatives you've considered
Commandline argument
-y
will do the same as the environment variable, and more convenient.Additional context
Help message can be added:
The scripts within
install.sh
are using/bin/sh
instead of/bin/bash
so some rewrites are necessary if the example code does not work as intended.The text was updated successfully, but these errors were encountered: