-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KThreesControlPlane ServerConfig always reverts to defaults #120
Comments
I'm already having a look at this, trying to fix it asap. |
I tried to add some breakpoint to the CustomDefaulter, and I observed the value remains |
@anmazzotti Could you check if this would help golang omitempty , it seems that we should use *bool when using with |
I'm indeed using pointers in the PR I opened yesterday to fix this. Somehow the kubebuilder defaults are a bit too sticky, but setting everything in the custom defaulter seem to work just fine. |
Does the issue got fixed? I have not tried with your PR yet, I have not noticed it has been changed to pointer XD |
I tested it locally and it seems to be fixed. I should be adding some e2e test, but I think that also needs porting of all current tests to v1beta2 manifests, so may take a bit. |
Using the
v1beta2
and configuring for example:After applying this config, the KThreesControlPlane defaults back to:
This was reported in the Slack channel in this thread.
The text was updated successfully, but these errors were encountered: