C warning in graphviz dependency

[philippgille]

What happened

Hi 👋 , thanks for creating and maintaining this project!

I recently updated tbls from v1.68.2 to latest (1.70.1 as of today), and got some warnings when installing via Go 1.21.3.

Not sure about the impact on tbls functionality though.

What you expected to happened

I expected no warnings during installation

What stack trace or error message from tbls did you see?

$ go install github.com/k1LoW/[email protected]
# github.com/goccy/go-graphviz/internal/ccall
In file included from common.c:5:
/Users/[redacted]/go/pkg/mod/github.com/goccy/[email protected]/internal/ccall/common/emit.c:165:35: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
/Users/[redacted]/go/pkg/mod/github.com/goccy/[email protected]/internal/ccall/common/emit.c:2540:24: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
/Users/[redacted]/go/pkg/mod/github.com/goccy/[email protected]/internal/ccall/common/emit.c:2596:35: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
/Users/[redacted]/go/pkg/mod/github.com/goccy/[email protected]/internal/ccall/common/emit.c:2602:35: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
/Users/[redacted]/go/pkg/mod/github.com/goccy/[email protected]/internal/ccall/common/emit.c:2612:31: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
/Users/[redacted]/go/pkg/mod/github.com/goccy/[email protected]/internal/ccall/common/emit.c:2623:31: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
/Users/[redacted]/go/pkg/mod/github.com/goccy/[email protected]/internal/ccall/common/emit.c:2628:31: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
/Users/[redacted]/go/pkg/mod/github.com/goccy/[email protected]/internal/ccall/common/emit.c:2641:28: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
/Users/[redacted]/go/pkg/mod/github.com/goccy/[email protected]/internal/ccall/common/emit.c:2650:33: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
/Users/[redacted]/go/pkg/mod/github.com/goccy/[email protected]/internal/ccall/common/emit.c:2659:32: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
/Users/[redacted]/go/pkg/mod/github.com/goccy/[email protected]/internal/ccall/common/emit.c:2668:32: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
# github.com/goccy/go-graphviz/internal/ccall
In file included from dotgen.c:15:
/Users/[redacted]/go/pkg/mod/github.com/goccy/[email protected]/internal/ccall/dotgen/dotsplines.c:2310:13: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
/Users/[redacted]/go/pkg/mod/github.com/goccy/[email protected]/internal/ccall/dotgen/dotsplines.c:2504:16: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]

Anything else we need to know?

I don't remember seeing that error when I installed the previous version, but trying just now with v1.68.2 it's the same warnings that are shown.

Environment

• tbls version: 1.70.1
• Database version: /
• OS ( Ubuntu bionic, macOS Calalina, WSL2, etc ): macOS Ventura
• Shell ( bash, zsh, poworshell, etc ): Bash
• Stacktrace or error message from tbls ( If you can, set DEBUG=1): /
• Config ( .tbls.yml ): /

[k1LoW]

@philippgille Thank you for your report!!

This is a go-graphviz related issue.
For example goccy/go-graphviz#77
At this time it is a warning, so we do not consider it a major problem in tbls.

[philippgille]

Ah great to see there's already a PR for the library. Perfect 👌

[k1LoW]

An amazing solution solved this problem!

https://github.com/goccy/go-graphviz/releases/tag/v0.2.0

Thank you @goccy !!!

ref: #625