Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps)!: update to Angular 19 #1871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps)!: update to Angular 19 #1871

wants to merge 1 commit into from
+4,279 −3,478

Conversation

arturovt
Copy link
Collaborator

No description provided.

@arturovt arturovt force-pushed the chore/ng19 branch 4 times, most recently from f856d38 to ffac768 Compare November 22, 2024 14:32
@arturovt arturovt linked an issue Nov 22, 2024 that may be closed by this pull request
Support for Angular 19 #1869
Open
@bobbyquantum bobbyquantum mentioned this pull request Nov 26, 2024
Open
@arturovt arturovt force-pushed the chore/ng19 branch 2 times, most recently from c71f014 to 451b05b Compare November 26, 2024 15:46
@arturovt arturovt marked this pull request as ready for review November 26, 2024 15:59
just-jeb
just-jeb approved these changes Nov 28, 2024
View reviewed changes
Copy link
Owner

@just-jeb just-jeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, one concern, should we merge #1860 into v19 update (as a breaking change)?
We can also merge the current PR as is but keep it in beta until we merge the breaking changes.
@arturovt wdyt?

@arturovt
Copy link
Collaborator Author

We can merge those breaking changes first and I will rebase this branch later.

@mshima
Copy link

mshima commented Nov 28, 2024

Hi, thanks to your work.

Unless a new v18 release is planned I think the v19 migration should be merged before.

  • those breaking changes seems to be only related to custom-esbuild which have limited usage.
  • this PR is much broader than the custom-esbuild only changes.
  • this PR is ready and will allow betas or even a final version of packages except esbuild like happened with jest in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonmert qmonmert qmonmert left review comments

@just-jeb just-jeb just-jeb approved these changes

@aggroman aggroman aggroman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Angular 19
5 participants
@arturovt @mshima @aggroman @just-jeb @qmonmert