About pinning rust compiler version.

[sandeshbhusal]

Hello! I'm an interested contributor for your project, but I am running an older rustc version due to personal reasons. I noticed that your repo does not have a rust-toolchain.toml file, and I think it would be great to have one, to help devs like me make contributions.

I was a bit confused about where this topic should go, and decided against creating an issue since it's not technically a "product feature". :)

[SanchithHegde]

Hey @sandeshbhusal, we appreciate you opening a discussion about this, as requirements for the build environment is something that can be easily overlooked.

As far as I understand, the rust-toolchain.toml file would be a necessity when a project requires a nightly compiler to build its crates. Because we'd prefer deterministic behavior for a payments system, we develop and build using only the stable toolchain. We do have our MSRV (1.65) included in some of the individual crates' manifests (although some of the newer crates in the workspace don't have it):

hyperswitch/crates/router/Cargo.toml

Line 7 in fee0e9d

rust-version = "1.65"

As far as I know, the only requirement for a nightly compiler in our project is for nightly rustfmt, which we have found to be producing the same formatted code across different nightly versions of rustfmt. If I've missed something regarding the need of a rust-toolchain.toml file, please do let me know. If there are valid reasons that I may have overlooked, we can include a rust-toolchain.toml file, and a PR for the same would be welcome.

[SanchithHegde]

Will be closing this since there's been no activity for ~3 months, and I think the initial question has been answered.