-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize the file browser toolbar via the settings #12196
Comments
Adding to 4.0 for consideration. |
This might depend on #11754 being fixed first for use in Notebook v7. |
Looks like the current toolbar customization applies to the document factories. Not sure it will be possible to adapt the current pieces such as cc @fcollonval who might have some input on this. |
Ideally in the case Notebook v7 it would be possible to register a new factory like it is already done here for the interface switcher in the notebook toolbar: And define overrides in a custom downstream settings file, for example to be able to make the toolbar look a bit more like classic if needed (disabling some items, inserting spacers to pull content to the right): |
One thing that could be tricky is the fact there can be multiple file browsers. It's not clear whether it will be possible to have something generic enough without making it too complicated. |
* Customize the file browser toolbar via the settings Fixes #12196 * Fix icon in menu for launcher * Fix tests * Address review suggestions * Apply suggestions from code review Co-authored-by: Jeremy Tuloup <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: Jeremy Tuloup <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Problem
Just like the notebook toolbar or file editor toolbar, it would be great if the file browser toolbar could also be configured via the settings.
Proposed Solution
Maybe we can follow a similar approach as the other factories, and place the toolbar items in the settings definition.
Additional context
This could also prove useful for customizing the notebook v7 toolbar (see https://github.com/jupyterlab/retrolab/issues/260#issuecomment-971202618 for more context):
The text was updated successfully, but these errors were encountered: