From 0356f8eb14c61096a5deab5ae83abd14dd6d5d08 Mon Sep 17 00:00:00 2001 From: David Brochart Date: Wed, 18 Dec 2024 11:06:22 +0100 Subject: [PATCH 1/4] Update event schema version type --- .../jupyter_server_ydoc/events/awareness.yaml | 2 +- .../jupyter-server-ydoc/jupyter_server_ydoc/events/fork.yaml | 2 +- .../jupyter-server-ydoc/jupyter_server_ydoc/events/session.yaml | 2 +- pyproject.toml | 2 ++ 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/awareness.yaml b/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/awareness.yaml index 41a76739..c8aeb647 100644 --- a/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/awareness.yaml +++ b/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/awareness.yaml @@ -1,6 +1,6 @@ "$id": https://schema.jupyter.org/jupyter_collaboration/awareness/v1 "$schema": "http://json-schema.org/draft-07/schema" -version: 1 +version: "1" title: Collaborative awareness events personal-data: true description: | diff --git a/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/fork.yaml b/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/fork.yaml index 0125fdf2..6042b46f 100644 --- a/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/fork.yaml +++ b/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/fork.yaml @@ -1,6 +1,6 @@ "$id": https://schema.jupyter.org/jupyter_collaboration/fork/v1 "$schema": "http://json-schema.org/draft-07/schema" -version: 1 +version: "1" title: Collaborative fork events personal-data: true description: | diff --git a/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/session.yaml b/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/session.yaml index 980ca205..dd91a80c 100644 --- a/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/session.yaml +++ b/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/session.yaml @@ -1,6 +1,6 @@ "$id": https://schema.jupyter.org/jupyter_collaboration/session/v1 "$schema": "http://json-schema.org/draft-07/schema" -version: 1 +version: "1" title: Collaborative session events personal-data: true description: | diff --git a/pyproject.toml b/pyproject.toml index ef923fd3..9c7359d3 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -106,6 +106,8 @@ filterwarnings = [ 'ignore:Unclosed Date: Wed, 18 Dec 2024 15:18:46 +0100 Subject: [PATCH 2/4] Tweak maxDiffPixelRatio --- ui-tests/playwright.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui-tests/playwright.config.js b/ui-tests/playwright.config.js index c609427b..35b805c0 100644 --- a/ui-tests/playwright.config.js +++ b/ui-tests/playwright.config.js @@ -20,7 +20,7 @@ module.exports = { }, expect: { toMatchSnapshot: { - maxDiffPixelRatio: 0.0001 + maxDiffPixelRatio: 0.01 } } }; From 1a606a06a639e0b5590b6cf038a5f995fb6cccd9 Mon Sep 17 00:00:00 2001 From: David Brochart Date: Wed, 18 Dec 2024 15:35:52 +0100 Subject: [PATCH 3/4] Set maxDiffPixelRatio to 0.001 Co-authored-by: Duc Trung Le --- ui-tests/playwright.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui-tests/playwright.config.js b/ui-tests/playwright.config.js index 35b805c0..09eff6b1 100644 --- a/ui-tests/playwright.config.js +++ b/ui-tests/playwright.config.js @@ -20,7 +20,7 @@ module.exports = { }, expect: { toMatchSnapshot: { - maxDiffPixelRatio: 0.01 + maxDiffPixelRatio: 0.001 } } }; From c16c79e4bbe94cb1af22f50bacdfe1b69bb03c0d Mon Sep 17 00:00:00 2001 From: David Brochart Date: Wed, 18 Dec 2024 15:48:48 +0100 Subject: [PATCH 4/4] Set maxDiffPixelRatio to 0.01 --- ui-tests/playwright.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui-tests/playwright.config.js b/ui-tests/playwright.config.js index 09eff6b1..35b805c0 100644 --- a/ui-tests/playwright.config.js +++ b/ui-tests/playwright.config.js @@ -20,7 +20,7 @@ module.exports = { }, expect: { toMatchSnapshot: { - maxDiffPixelRatio: 0.001 + maxDiffPixelRatio: 0.01 } } };