Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nbconvert jumps to the wrong link in collaboration mode #151

Open
SaturnTsen opened this issue May 17, 2023 · 11 comments
Open

Nbconvert jumps to the wrong link in collaboration mode #151

SaturnTsen opened this issue May 17, 2023 · 11 comments
Labels
bug Something isn't working

Comments

@SaturnTsen
Copy link

Describe the bug
Nbconvert jumps to the wrong link in collaboration mode.

To Reproduce

  1. Install and activate jupyter-collaboration
  2. Open any .ipynb file
  3. File - Save and Export Notebook As - LaTeX (or other options)
  4. The server returns 404, because the the browser goes to /nbconvert/latex/RTC%3AFILENAME.ipynb?download=true instead of /nbconvert/latex/FILENAME.ipynb?download=true

Expected behavior
the browser goes to /nbconvert/latex/FILENAME.ipynb?download=true

Screenshots
image

image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Edge (Chromium)
  • Server Version:
    CentOS : LSB Version core-4.1-amd64:core-4.1-noarch
    Conda Version: 23.3.1
    Python : 3.10.9
    IPython : 8.13.1
    ipykernel : 6.22.0
    ipywidgets : not installed
    jupyter_client : 8.2.0
    jupyter_core : 5.3.0
    jupyter_server : 2.5.0
    jupyterlab : 4.0.0rc0
    nbclient : 0.7.4
    nbconvert : 7.3.1
    nbformat : 5.8.0
    notebook : 7.0.0b1
    qtconsole : not installed
    traitlets : 5.9.0
@SaturnTsen SaturnTsen added the bug Something isn't working label May 17, 2023
@welcome
Copy link

welcome bot commented May 17, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@hbcarlos
Copy link
Member

Thanks @minger233.

We will need to fix this in JupyterLab.

@tuncbkose
Copy link

tuncbkose commented Aug 23, 2023

What would be the right way to fix this? I can imagine stripping the RTC: part somewhere (here?).

But I don't know if that fixes the general problem of a different notebook path being reported/passed around just because collaboration is active, for code that expects path to be just the file path.

@ykazakov
Copy link

There is a similar problem in nbgrader caused by the RTC: part in the path: jupyter/nbgrader#1836

@tylerpotts
Copy link

Also having this issue with png image files in the imageviewer using jupyterlab==4.0.7 and jupyter-collaboration==1.2.0

image

When looking at the path of the image I'm trying to open it's http://localhost:8888/lab/workspaces/auto-s/tree/RTC%3Aimage.png. If I remove the RTC%3A it works as expected.

@milandeepbassi
Copy link

jupyter/nbgrader#1836 For this issue is it caused by Jupyter colab or is it an nbgrader issue?

@emacsen
Copy link

emacsen commented Oct 24, 2024

It's been about eight months since the last message on this bug. Is there any update on it?

@davidbrochart
Copy link
Collaborator

These two PRs will allow to get rid of the RTC: prefix, which should fix this issue:

@martinRenou
Copy link
Member

martinRenou commented Oct 25, 2024

These two PRs will allow to get rid of the RTC: prefix, which should fix this issue:

I believe this is somewhat orthogonal though. JupyterLab should handle the drive prefix properly for the nbconvert exporters.

@ykazakov
Copy link

Isn't this the same kind of issue as #202?

@davidbrochart
Copy link
Collaborator

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

9 participants