Fixes the initialization of rooms #1083
hbcarlos
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
test.yml
on: pull_request
Matrix: Test Python
check_links
1m 35s
ui_tests
10m 47s
Install from SDist and Test
0s
Annotations
16 errors, 11 warnings, and 1 notice
|
Test Python (ubuntu-latest, 3.11)
Process completed with exit code 4.
|
|
Test Python (ubuntu-latest, 3.8)
Process completed with exit code 4.
|
|
Test Python (macos-latest, 3.11)
Process completed with exit code 4.
|
|
Test Python (windows-latest, 3.8)
Process completed with exit code 1.
|
|
Test Python (windows-latest, 3.11)
Process completed with exit code 1.
|
|
Test Python (macos-latest, 3.8)
Process completed with exit code 4.
|
|
tests/collaborationpanel.spec.ts:89:7 › One client › collaborators list should be updated:
ui-tests/tests/collaborationpanel.spec.ts#L93
1) tests/collaborationpanel.spec.ts:89:7 › One client › collaborators list should be updated ─────
Error: Timed out 5000ms waiting for expect(received).toHaveCount(expected) // deep equality
Expected: 1
Received: 0
Call log:
- expect.toHaveCount with timeout 5000ms
- waiting for locator('.jp-SidePanel.jp-RTCPanel').first().locator('.jp-CollaboratorsList .jp-Collaborator')
- locator resolved to 0 elements
- unexpected value "0"
- locator resolved to 0 elements
- unexpected value "0"
- locator resolved to 0 elements
- unexpected value "0"
- locator resolved to 0 elements
- unexpected value "0"
- locator resolved to 0 elements
- unexpected value "0"
- locator resolved to 0 elements
- unexpected value "0"
- locator resolved to 0 elements
- unexpected value "0"
- locator resolved to 0 elements
- unexpected value "0"
- locator resolved to 0 elements
- unexpected value "0"
91 |
92 | // Expect the collaborators list to contain 1 element.
> 93 | await expect(panel.locator('.jp-CollaboratorsList .jp-Collaborator')).toHaveCount(1);
| ^
94 |
95 | // Log out the collaborator and expect the collaborators list to be empty.
96 | await guestPage.click('.lm-MenuBar-itemLabel:text("File")');
at /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/tests/collaborationpanel.spec.ts:93:75
|
|
tests/collaborationpanel.spec.ts:102:7 › One client › clicking on collaborator should open to its current document:
ui-tests/tests/collaborationpanel.spec.ts#L116
2) tests/collaborationpanel.spec.ts:102:7 › One client › clicking on collaborator should open to its current document
Error: Timed out 5000ms waiting for expect(received).toHaveCount(expected) // deep equality
Expected: 1
Received: 0
Call log:
- expect.soft.toHaveCount with timeout 5000ms
- waiting for locator('.jp-SidePanel.jp-RTCPanel').first().locator('.jp-CollaboratorsList .jp-Collaborator')
- locator resolved to 0 elements
- unexpected value "0"
- locator resolved to 0 elements
- unexpected value "0"
- locator resolved to 0 elements
- unexpected value "0"
- locator resolved to 0 elements
- unexpected value "0"
- locator resolved to 0 elements
- unexpected value "0"
- locator resolved to 0 elements
- unexpected value "0"
- locator resolved to 0 elements
- unexpected value "0"
- locator resolved to 0 elements
- unexpected value "0"
- locator resolved to 0 elements
- unexpected value "0"
114 |
115 | // Expect the collaborators list to contain one collaborator.
> 116 | await expect.soft(panel.locator('.jp-CollaboratorsList .jp-Collaborator')).toHaveCount(1);
| ^
117 |
118 | const notebookName = await page.notebook.createNew() || '';
119 |
at /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/tests/collaborationpanel.spec.ts:116:80
|
|
tests/collaborationpanel.spec.ts:102:7 › One client › clicking on collaborator should open to its current document:
ui-tests/tests/collaborationpanel.spec.ts#L1
2) tests/collaborationpanel.spec.ts:102:7 › One client › clicking on collaborator should open to its current document
Test timeout of 60000ms exceeded.
|
|
tests/collaborationpanel.spec.ts:102:7 › One client › clicking on collaborator should open to its current document:
ui-tests/tests/collaborationpanel.spec.ts#L118
2) tests/collaborationpanel.spec.ts:102:7 › One client › clicking on collaborator should open to its current document
Error: page.waitForSelector: Target closed
=========================== logs ===========================
waiting for locator('.jp-Dialog') to be visible
============================================================
116 | await expect.soft(panel.locator('.jp-CollaboratorsList .jp-Collaborator')).toHaveCount(1);
117 |
> 118 | const notebookName = await page.notebook.createNew() || '';
| ^
119 |
120 | // First expect the new page only contains the Launcher tab.
121 | const dockTabs = guestPage.locator('#jp-main-dock-panel > .lm-DockPanel-tabBar > ul');
at NotebookHelper.createNew (/home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/node_modules/@jupyterlab/galata/src/helpers/notebook.ts:1212:16)
at /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/tests/collaborationpanel.spec.ts:118:26
|
|
tests/collaborationpanel.spec.ts:178:7 › Three clients › Without document:
ui-tests/tests/collaborationpanel.spec.ts#L1
3) tests/collaborationpanel.spec.ts:178:7 › Three clients › Without document ─────────────────────
Test timeout of 60000ms exceeded.
|
|
tests/collaborationpanel.spec.ts:178:7 › Three clients › Without document:
ui-tests/tests/collaborationpanel.spec.ts#L183
3) tests/collaborationpanel.spec.ts:178:7 › Three clients › Without document ─────────────────────
Error: proxy.waitForSelector: Target closed
=========================== logs ===========================
waiting for locator('text=jovyan_0') to be visible
============================================================
181 | // wait for guest clients
182 | for (let i = 0; i < numClients; i++) {
> 183 | await page.waitForSelector(`text=jovyan_${i}`);
| ^
184 | }
185 |
186 | const tab = await page.sidebar.getContentPanel('left');
at /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/tests/collaborationpanel.spec.ts:183:18
|
|
tests/collaborationpanel.spec.ts:192:7 › Three clients › With document:
ui-tests/tests/collaborationpanel.spec.ts#L1
4) tests/collaborationpanel.spec.ts:192:7 › Three clients › With document ────────────────────────
Test timeout of 60000ms exceeded.
|
|
tests/collaborationpanel.spec.ts:192:7 › Three clients › With document:
ui-tests/tests/collaborationpanel.spec.ts#L194
4) tests/collaborationpanel.spec.ts:192:7 › Three clients › With document ────────────────────────
Error: page.waitForSelector: Target closed
=========================== logs ===========================
waiting for locator('.jp-Dialog') to be visible
============================================================
192 | test('With document', async ({ page, request, tmpPath }) => {
193 | // Renaming does not work
> 194 | await page.notebook.createNew();
| ^
195 | await page.notebook.open('Untitled.ipynb');
196 |
197 | await Promise.all(
at NotebookHelper.createNew (/home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/node_modules/@jupyterlab/galata/src/helpers/notebook.ts:1212:16)
at /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/tests/collaborationpanel.spec.ts:194:5
|
|
tests/notebook.spec.ts:104:7 › Initialization › Create a notebook:
ui-tests/tests/notebook.spec.ts#L1
5) tests/notebook.spec.ts:104:7 › Initialization › Create a notebook ─────────────────────────────
Test timeout of 60000ms exceeded.
|
|
tests/notebook.spec.ts:104:7 › Initialization › Create a notebook:
ui-tests/tests/notebook.spec.ts#L106
5) tests/notebook.spec.ts:104:7 › Initialization › Create a notebook ─────────────────────────────
Error: page.waitForSelector: Target closed
=========================== logs ===========================
waiting for locator('.jp-Dialog') to be visible
============================================================
104 | test('Create a notebook', async ({ page, request, tmpPath }) => {
105 | // Renaming does not work
> 106 | await page.notebook.createNew();
| ^
107 | await page.notebook.activate(pathUntitled);
108 | await guestPage.filebrowser.refresh();
109 | await guestPage.notebook.open(pathUntitled);
at NotebookHelper.createNew (/home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/node_modules/@jupyterlab/galata/src/helpers/notebook.ts:1212:16)
at /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/tests/notebook.spec.ts:106:5
|
|
Run pre-commit hook
The following actions uses node12 which is deprecated and will be forced to run on node16: pre-commit/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Run pre-commit hook:
packages/collaboration/src/collaboratorspanel.tsx#L78
Forbidden non-null assertion
|
|
Run pre-commit hook:
packages/collaboration/src/cursors.ts#L171
Forbidden non-null assertion
|
|
Run pre-commit hook:
packages/collaboration/src/cursors.ts#L235
Forbidden non-null assertion
|
|
Run pre-commit hook:
packages/collaboration/src/cursors.ts#L285
Forbidden non-null assertion
|
|
Run pre-commit hook:
packages/collaboration/src/menu.ts#L65
Forbidden non-null assertion
|
|
Run pre-commit hook:
packages/collaboration/src/menu.ts#L70
Forbidden non-null assertion
|
|
Run pre-commit hook:
packages/collaboration/src/menu.ts#L76
Forbidden non-null assertion
|
|
Run pre-commit hook:
packages/collaboration/src/menu.ts#L78
Forbidden non-null assertion
|
|
Run pre-commit hook:
packages/collaboration/src/userinfopanel.tsx#L26
Forbidden non-null assertion
|
|
Run pre-commit hook:
packages/collaboration/src/userinfopanel.tsx#L32
Forbidden non-null assertion
|
|
🎭 Playwright Run Summary
7 failed
tests/collaborationpanel.spec.ts:89:7 › One client › collaborators list should be updated ──────
tests/collaborationpanel.spec.ts:102:7 › One client › clicking on collaborator should open to its current document
tests/collaborationpanel.spec.ts:178:7 › Three clients › Without document ──────────────────────
tests/collaborationpanel.spec.ts:192:7 › Three clients › With document ─────────────────────────
tests/notebook.spec.ts:104:7 › Initialization › Create a notebook ──────────────────────────────
tests/notebook.spec.ts:127:7 › Initialization › Open a notebook ────────────────────────────────
tests/user-menu.spec.ts:58:5 › should copy the shared link with filepath ───────────────────────
3 skipped
6 passed (6.9m)
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
jupyter-collaboration-playwright-report
Expired
|
12.5 MB |
|