Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on a way to distinguish bots & users #117

Open
dlqqq opened this issue Dec 9, 2024 · 1 comment
Open

Decide on a way to distinguish bots & users #117

dlqqq opened this issue Dec 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@dlqqq
Copy link
Member

dlqqq commented Dec 9, 2024

Problem

Currently, the YChat API doesn't make a distinction between users connected from a browser & bots connected from a server extension.

Proposed Solution

Add some way to distinguish between human users & server bots in the return type of YChat.get_users() and other similar methods.

We should also consider renaming this method to YChat.get_clients(), since a client may be a user or a bot.

@dlqqq dlqqq added the enhancement New feature or request label Dec 9, 2024
@brichet
Copy link
Collaborator

brichet commented Dec 10, 2024

Thanks @dlqqq for opening this.

Although I agree with the need to distinguish the type of client, I wonder where this should live.

  • This information seems more related to jupyter-ai than jupyter-chat itself. We could allow this additional information in jupyter-chat, so that it can be customized in other extensions that use it.
  • There are currently some work in progress for a suggestions system in collaborative document (e.g. Support suggestions jupyter-collaboration#292). We could easily imagine suggestions from a bot. In this case, I believe that this information should be define at a Jupyter level, to be used by any extension.

And to complete this issue, we should also consider that bot users may come from the front end, e.g. https://github.com/jupyterlite/ai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants