Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendered code blocks lack backgrounds in JupyterLab 4.3.0+ #109

Closed
dlqqq opened this issue Dec 4, 2024 · 1 comment · Fixed by #111
Closed

Rendered code blocks lack backgrounds in JupyterLab 4.3.0+ #109

dlqqq opened this issue Dec 4, 2024 · 1 comment · Fixed by #111
Labels
bug Something isn't working

Comments

@dlqqq
Copy link
Member

dlqqq commented Dec 4, 2024

Description

Code blocks lack gray backgrounds in JupyterLab 4.3.0+ due to CSS changes introduced by JupyterLab 4.3.0. This makes messages hrader to read as they blend in with the code blocks.

Screenshot 2024-12-03 at 5 14 40 PM

Reproduce

  1. Upgrade JupyterLab to v4.3.0+.
  2. Run Jupyter AI off of this branch: [v3-dev] Initial migration to jupyterlab-chat jupyter-ai#1043
  3. Make Jupyternaut generate a code block
  4. Verify that the error exists

Proposed solution

Port jupyterlab/jupyter-ai#1104 to @jupyter/chat.

@dlqqq dlqqq added the bug Something isn't working label Dec 4, 2024
@brichet
Copy link
Collaborator

brichet commented Dec 4, 2024

Thanks @dlqqq for opening this, and providing a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants