Catch error on non plaintext files in @file and reply gracefully in chat
#1106
+50
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlqqq
reviewed
Nov 14, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@meeseeksdev please backport to v3-dev |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter-ai
that referenced
this pull request
Nov 15, 2024
…file` and reply gracefully in chat
dlqqq
pushed a commit
that referenced
this pull request
Nov 15, 2024
…reply gracefully in chat (#1110) Co-authored-by: Sanjiv Das <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1044
If the file format (e.g. PDF) cannot be read in plaintext by
file.read()the error messages appear in chat. This PR emands toe code to make sure the error is trapped and a message is sent to the user in chat explaining that@filecannot handle context files that are not plaintext.Additional work is needed to handle files that can be converted to plaintext and then used in context. Next step: convert PDF files into plaintext to expand the set of file formats in
@file.