Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot save via chat settings #933

Closed
dlqqq opened this issue Aug 5, 2024 · 1 comment · Fixed by #935
Closed

Cannot save via chat settings #933

dlqqq opened this issue Aug 5, 2024 · 1 comment · Fixed by #935
Labels
bug Something isn't working

Comments

@dlqqq
Copy link
Member

dlqqq commented Aug 5, 2024

Description

There is no way to save through the settings UI when any language/embedding model requires an API key. Bug was introduced by #918.

Screen.Recording.2024-08-05.at.4.40.58.PM.mov

Reproduce

  1. Select any language model that requires an API key
  2. Save settings
  3. Try to save settings again

Expected behavior

Jupyter AI should work.

@dlqqq dlqqq added the bug Something isn't working label Aug 5, 2024
@dlqqq
Copy link
Member Author

dlqqq commented Aug 5, 2024

The issue is that the request payload sent to POST /ai/config always includes an empty API key value for API keys required by the current language/embedding model. An API key should be included in the request payload only when one is being created or updated.

Screenshot 2024-08-05 at 4 42 10 PM

I called this out in my review, but received pushback that I did not have time to verify, so I merged #918 anyways. Since this is my responsibility, I will open a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant