Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter AI plugin schema is never loaded; contains unused cell toolbar and menus #871

Closed
krassowski opened this issue Jul 5, 2024 · 1 comment · Fixed by #873
Closed
Labels
bug Something isn't working

Comments

@krassowski
Copy link
Member

I was trying to add a shortcut for #799 and noticed that there is schema/plugin.json which contains a cell toolbar button and menu actions:

"jupyter.lab.toolbars": {
"Cell": [
{
"name": "ai:explain-or-codify-cell",
"command": "ai:explain-or-codify-cell",
"rank": 10
}
]
},
"jupyter.lab.menus": {
"context": [
{
"name": "ai:explain-code-cell",
"command": "ai:explain-code-cell",
"selector": ".jp-CodeCell",
"rank": 500
},
{
"name": "ai:codify-md-cell",
"command": "ai:codify-md-cell",
"selector": ".jp-MarkdownCell",
"rank": 510
},
{
"name": "ai:generate-from-notebook-selection",
"command": "ai:generate-from-notebook-selection",
"selector": ".jp-NotebookPanel",
"rank": 520
},
{
"name": "ai:generate-from-editor-selection",
"command": "ai:generate-from-editor-selection",
"selector": ".jp-FileEditor",
"rank": 520
}
]
},

However, these do not show up int the UI because the schema is not correctly hooked up, and these commands are not defined. Is it intended?

Also, I am quite confused on the design directions because the original version of the UI did contain a dedicated cell toolbar button but it seems this was changed early on but I cannot find an issue nor PR documenting rationale for this change.

@krassowski krassowski added the bug Something isn't working label Jul 5, 2024
@krassowski
Copy link
Member Author

I see the associated commands were removed in #77 but I do not see any relevant discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant