-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error log when starting up extension #839
Comments
For reference in other cases we get a warning, which I think is fine:
|
We are seeing a spurious error logged not just for mistral, but for 3 other model providers as well:
This does not just add noise to the logs that users see at startup, but worse is that it makes it harder for users to hook up meaningful alerting so that someone can get paged when (real) errors are logged by anything writing to stdout/stderr. |
Since it is expected that not all embeddings model providers will be loadable, it is wrong to log the case that one cannot be loaded with level 'error' or even 'warning'. Resolves jupyterlab#839.
Submitted #1119 to address this. |
Since it is expected that not all model providers will be loadable, it is wrong to log the case that one cannot be loaded with level 'error'. Resolves jupyterlab#839.
Description
Reproduce
pip install jupyter-ai
(without[all]
)jupyter lab
Expected behavior
No errors on startup; lack of
langchain_mistralai
is not an error.Context
2.17.0
The text was updated successfully, but these errors were encountered: