Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent overriding server_settings on base provider class #825

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Prevent overriding server_settings on base provider class #825

merged 1 commit into from
Jun 12, 2024

Conversation

krassowski
Copy link
Member

Follow-up to #777 (comment)

Prevents overriding server_settings on base provider class

@krassowski krassowski added the maintenance Change related to maintenance of the repository label Jun 10, 2024
@krassowski krassowski force-pushed the read-only-server-settings branch from c62207b to a13b5a6 Compare June 10, 2024 09:57
@krassowski krassowski marked this pull request as ready for review June 10, 2024 09:58
@dlqqq dlqqq force-pushed the read-only-server-settings branch from a13b5a6 to b45572c Compare June 12, 2024 15:58
dlqqq
dlqqq approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krassowski Thank you! Merging.

@dlqqq dlqqq enabled auto-merge (squash) June 12, 2024 15:59
@dlqqq dlqqq merged commit 81e647d into jupyterlab:main Jun 12, 2024
8 checks passed
@krassowski
Copy link
Member Author

@dlqqq thank you! What would you say about releasing this and #777 as a 2.17 pre-release today? I can do this if you do not have time and are ok with this.

@krassowski krassowski deleted the read-only-server-settings branch September 21, 2024 13:34
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
@krassowski @Marchlak
Prevent overriding server_settings on base provider class (jupyterl…
fea0aee 
…ab#825)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlqqq dlqqq dlqqq approved these changes

Assignees
No one assigned
Labels
maintenance Change related to maintenance of the repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krassowski @dlqqq