Use new langchain-openai partner package
#653
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
@jtpio I really don't have the time to build up the Jupyter AI development environment but since I was working with it yesterday I figured I'd create a PR for a bug I'd noticed. I would like to note that the tests passed, which means there was never a test to check this code path, which seems worth noting given how common I'd assume it is. I hope this PR doesn't break anything and would encourage someone to actually test it. |
|
@startakovsky Thank you for this PR! I was out sick last week, so I only just got the chance to review this. Right now, I'm gathering more info on this issue, and will return with feedback. Appreciate your patience! 🤗 |
dlqqq
changed the title
langchain-openai partner package
for more information, see https://pre-commit.ci
|
@startakovsky Thank you for contributing this PR! Sorry that it had escaped my attention for a while, but I just got a chance to review this again. I pushed some commits that:
|
|
@dlqqq 
One side-effect of this change is that if users upgrade to this version, and not have the 
Fixing this is beyond the scope of this PR, but we probably need a richer experience in settings or chat to capture that there is a dependent package missing. |
|
Thanks guys, seems good to go! One thing: Is there a need to have one or more tests on this code path? |
|
@3coins Thank you for the review! This is expected. If the model provider cannot be loaded by the ConfigManager, the ConfigManager sets the language model to I agree that this is something we should address with better messaging (e.g. a warning banner), and that this should be done in a future PR. @startakovsky There's less utility in adding tests here, since we are mainly relying on logic from the |
|
Congrats on your first merged pull request in this project! 🎉 |
|
@meeseeksdev please backport to 1.x |
Co-authored-by: Steven <[email protected]>
* Import ChatOpenAI and AzureChatOpenAI from the updated langchain location: * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update pyproject.toml, add `langchain-openai` as an optional dependency * remove direct dependency on openai and tiktoken packages * move openai providers to separate module to keep langchain_openai optional * update openai provider dependencies in docs * pre-commit --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: David L. Qiu <[email protected]>
This fixes #652 , I think. I wonder if I needed to create some tests. Hope this helps get a head start on this issue. What a great tool this is.