Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base API URL for Embedding Model #587

Closed
S1M0N38 opened this issue Jan 19, 2024 · 2 comments · Fixed by #1136
Closed

Base API URL for Embedding Model #587

S1M0N38 opened this issue Jan 19, 2024 · 2 comments · Fixed by #1136
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@S1M0N38
Copy link

S1M0N38 commented Jan 19, 2024

Problem

I think it could be useful to be able to setup up Base API URL for Embedding Model as well. For example if we use a custom Base API URL in Language Model to query OpenAI gpt-4, it is reasonable that we want to use the same custom Base API URL when hitting /embeddings endpoint.

Proposed Solution

Screenshot 2024-01-19 at 11 50 22

From the frontend prospective I think that a new text field, similar to the Language model Base API URL
is consistent with the design principle.

I'm not sure sure about the backend implementation.

@S1M0N38 S1M0N38 added the enhancement New feature or request label Jan 19, 2024
Copy link

welcome bot commented Jan 19, 2024

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@dlqqq dlqqq added this to the Priority milestone Nov 27, 2024
@dlqqq
Copy link
Member

dlqqq commented Nov 27, 2024

Thanks for reporting this issue! Sorry this went undiscovered for so long. I've assigned another contributor to this issue and added it to a milestone for tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants