-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LangChain v0.1.0 #572
Merged
Merged
LangChain v0.1.0 #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlqqq
force-pushed
the
resolve-langchain-conflicts
branch
from
January 10, 2024 01:58
04c985a
to
f7a752c
Compare
JasonWeill
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
3coins
reviewed
Jan 10, 2024
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter-ai
that referenced
this pull request
Jan 10, 2024
dlqqq
added a commit
that referenced
this pull request
Jan 10, 2024
Co-authored-by: david qiu <[email protected]>
Would love to see this in a release to avoid deps in my environment being downgraded. |
@dhirschfeld Tentatively, we are planning a minor release tomorrow. Thanks for your patience! 🤗 |
This was referenced Jan 18, 2024
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
* implement ProviderMetaclass * add ProviderMetaclass test * bump langchain to v0.1.0 * migrate import statements deprecated by langchain v0.1 * lint
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* implement ProviderMetaclass * add ProviderMetaclass test * bump langchain to v0.1.0 * migrate import statements deprecated by langchain v0.1 * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the weird conflict that newer LangChain packages had introduced, documented in #558. This PR re-defines the metaclass used by Pydantic to preserve our class attributes. This means that we are now free to name the class attributes on our providers however we'd like, without having to worry about whether the next version added a Pydantic field or not.
Since most of the effort was in defining and testing the metaclass, it was relatively simple to remove our existing version pins on LangChain and upgrade to
langchain>=0.1.0
. So I included those changes here as well.This PR has the added benefit of not introducing any breaking API changes, as it does not rename the
Provider.name
attribute.