Fixes lookup for custom chains #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlqqq
force-pushed
the
custom-chain-handling
branch
from
4ea716a to
9c91b6a
Compare
dlqqq
approved these changes
Jan 3, 2024
Comment on lines
+424
to
429
| # custom_model_registry maps keys to either a model name (a string) or an LLMChain. | ||
| # If this is an alias to another model, expand the full name of the model. | ||
| if model_id in self.custom_model_registry and isinstance( | ||
| self.custom_model_registry[model_id], str | ||
| ): | ||
| model_id = self.custom_model_registry[model_id] |
There was a problem hiding this comment.
Quick comment: it seems like it would be easier to re-define self.custom_model_registry to have values also be LLMChains in the case of an alias key. No need to do that in this PR if it's too big of a change though.
|
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter-ai
that referenced
this pull request
Jan 3, 2024
JasonWeill
added a commit
that referenced
this pull request
Jan 3, 2024
Co-authored-by: Jason Weill <[email protected]>
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #541, opened by @jamesjun (thank you!). Expands aliases to their full model name only when the alias is to a model name. When the alias is to a custom chain, it is not expanded to a function object.
Tested using
commands.ipynbin the example files.