Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pip install error #550

Closed
wants to merge 2 commits into from
Closed

Conversation

jamesjun
Copy link
Contributor

Fixed pip install error by adding [tool.hatch.build.targets.wheel] section in pyproject.toml.

To reproduce the error run pip install -e ..

@JasonWeill JasonWeill added the bug Something isn't working label Dec 27, 2023
@dlqqq
Copy link
Member

dlqqq commented Dec 27, 2023

@jamesjun Thanks for this PR! We appreciate others taking their time to contribute. I want to highlight two points:

  1. Contributors and developers should run jlpm dev-install to install Jupyter AI locally in a dev environment. They should not try to run pip install . on the "top-level package" at the root of the repository, since this is a monorepo containing multiple packages. The top-level package doesn't really do anything yet, and exists mainly to force our build & CI tools to work.
  2. I'm working on a PR to use the top-level package to gather shared dev & test dependencies. However, this won't automatically install jupyter-ai and jupyter-ai-magics. It's meant to be installed via jlpm dev-install. See: WIP: Gather shared Python dependencies #544.

Because of these two points, I'm going to tentatively close the PR. Please reply with feedback if you don't agree with this, and I will address it. Thank you!

@dlqqq dlqqq closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants