-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Notebook 7 #504
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
Maybe the following could be replaced by
Since |
Thanks for bringing this up. We have some early UX designs for a slightly different (optional) UX that would work well in notebook. Certainly the inline completer stuff in #465 should work in notebook, but we would like to have a chat experience as well. @andrii-i do you have some of the UX mocks we did for the lightweight chat UX for cells (I think we called in a "popup UX" or something? |
Just FYI, the chat could already by placed in the left or right sidebar: I think that the selection-oriented pop-up could be very useful for reformatting and infill tasks (and not hard to implement given CodeMirror6 uses its own, programmatic selection layer). I could also see the chat as optionally configurable mini-window that can be dragged around, though if you are interested in enabling users today, placing the chat in the sidebar is a no-brainer. |
Looking at the code, there seems to be some components that expect to work on a
LabShell
only:jupyter-ai/packages/jupyter-ai/src/selection-watcher.ts
Line 102 in 9c69a7b
Which can prevent using the extension in other lab-based applications such as Notebook 7.
Maybe there can be a way to make
jupyter-ai
work in more lab-based applications? Even if only a limited set of features is available.For instance this could allow for code completions in Notebook 7.1 (based on #465). Below is an example running https://github.com/krassowski/jupyterlab-transformers-completer:
inline-completer.mp4
The text was updated successfully, but these errors were encountered: