Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add baidu's ERNIE-Bot and ERNIE-Bot-4 support #478

Closed
wants to merge 13 commits into from
Closed

add baidu's ERNIE-Bot and ERNIE-Bot-4 support #478

wants to merge 13 commits into from

Conversation

markqiu
Copy link
Contributor

@markqiu markqiu commented Nov 17, 2023

add baidu's ERNIE-Bot and ERNIE-Bot-4 support

@markqiu markqiu marked this pull request as ready for review November 17, 2023 14:02
@markqiu markqiu marked this pull request as draft November 25, 2023 07:27
@markqiu markqiu marked this pull request as ready for review November 25, 2023 07:27
@krassowski krassowski added the enhancement New feature or request label Nov 25, 2023
@JasonWeill JasonWeill mentioned this pull request Dec 18, 2023
Closed
@JasonWeill
Copy link
Collaborator

@markqiu Thank you for opening this pull request! Sorry for the delay in getting back to you.

I found that your change uses the MultiEnvAuthStrategy strategy to authenticate, using keys QIANFAN_AK and QIANFAN_SK. The %ai list magic command and the chat UI do not handle multi-key authentication. I opened #525 to cover this. No existing providers use this strategy, so #525 does not reflect a bug in existing providers, but a developer needs to fix #525 before your change will be fully functional.

If you can modify this pull request to address #525 as well, we would be interested in accepting and merging your change. Thank you for your interest in improving Jupyter AI!

@JasonWeill JasonWeill added the status:Blocked Requires another task to be completed label Dec 18, 2023
@JasonWeill JasonWeill mentioned this pull request Dec 20, 2023
Merged
@JasonWeill
Copy link
Collaborator

#531 supersedes this PR; I incorporated @markqiu 's changes with code fixes that address #525. Thank you so much for your contribution!

@JasonWeill JasonWeill closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request status:Blocked Requires another task to be completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markqiu @JasonWeill @krassowski