Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code output format in IPython #1155

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

divyansshhh
Copy link
Contributor

In an IPython terminal, using code format doesn't copy the code to the output cell but this works in a JupyterLab cell. Removing the payload_manager and using the set_next_input method directly fixes this behavior in IPython while maintaining the functionality in JupyterLab

@srdas srdas added the bug Something isn't working label Dec 18, 2024
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divyansshhh Awesome, thank you for the bug fix! Looks good. 🤗

CI failure is not related. I will help get the checks passed.

In an IPython terminal, using `code` format doesn't copy the code to the
output cell but this works in a JupyterLab cell. Removing the
payload_manager and using the `set_next_input` method directly
fixes this behavior in IPython while maintaining the
functionality in JupyterLab
@dlqqq dlqqq force-pushed the fix/code-format-ipython-magic branch from 31ae0f7 to 1932f75 Compare December 18, 2024 19:40
@dlqqq dlqqq merged commit 2e80956 into jupyterlab:main Dec 18, 2024
10 checks passed
@dlqqq
Copy link
Member

dlqqq commented Dec 18, 2024

@meeseeksdev please backport to v3-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants