Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README instructions need updating #270

Closed
psychemedia opened this issue Nov 19, 2024 · 1 comment · Fixed by #271
Closed

README instructions need updating #270

psychemedia opened this issue Nov 19, 2024 · 1 comment · Fixed by #271
Labels
bug Something isn't working

Comments

@psychemedia
Copy link
Contributor

The command for installing the template in the README:

copier https://github.com/jupyterlab/extension-template .

seems to be broken.

I had to run:

copier copy https://github.com/jupyterlab/extension-template . --trust

(The --trust was for jinja templates.)
@psychemedia psychemedia added the bug Something isn't working label Nov 19, 2024
@jtpio
Copy link
Member

jtpio commented Nov 19, 2024

Thanks @psychemedia for reporting.

Probably it's because it was for the previous version 7 of copier?

image

I guess it would still make sense to update the example to the latest version of copier, to align with the extension template: https://github.com/jupyterlab/extension-template

If you would like to open a PR that would be great, thanks!

@psychemedia psychemedia mentioned this issue Nov 20, 2024
Merged
fcollonval added a commit that referenced this issue Nov 25, 2024
@psychemedia @fcollonval
Update copier command (copier 7.2->9.2) (#271)
7f5cd10 
* Update README.md - copier~=9.2

Update version of `copier` to match [`jupyterlab/extension-template`](https://github.com/jupyterlab/extension-template).

* Update copier copy command

* Update copier copy command

Fixes: #270

* Update hello-world/README.md

Co-authored-by: Frédéric Collonval <[email protected]>

* Update mimerenderer/README.md

Co-authored-by: Frédéric Collonval <[email protected]>

* Update server-extension/README.md

Co-authored-by: Frédéric Collonval <[email protected]>

---------

Co-authored-by: Frédéric Collonval <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update copier command (copier 7.2->9.2) psychemedia/extension-examples
2 participants
@psychemedia @jtpio