Hi @GeorgianaElena , just catching up with this on my phone now. Personally, I quite like your idea of removing all the kv_proxy / consul and etcd proxy code. (Not sure if I saw you'd removed relevant code in install.py, too?).

It will certainly make the PR's smaller, and probably a lot tidier than just commenting out the relevant test fixture parameters in test_proxy.py and test_traefik_api_auth.py, which is what I've been doing.

One comment on this relating to the readthedocs failing. It's something to do with sphinx v4 removing PyClassmember. If you pull a new version of autodoc_traits.py, then it will build okay. I initially thought this was installed with pip, but then saw you've included a copy, in https://github.com/jupyterhub/traefik-proxy/tree/master/docs/sphinxext

Anyway, grab a new copy from here and the docs will build okay:-
https://github.com/jupyterhub/autodoc-traits/blob/main/autodoc_traits/autodoc_traits.py

Will try and figure out how to rebase my traefik-v2-file branch against this one later today.

Cheers,
Alex

Hi @GeorgianaElena , just catching up with this on my phone now. Personally, I quite like your idea of removing all the kv_proxy / consul and etcd proxy code. (Not sure if I saw you'd removed relevant code in install.py, too?).

I didn't actually removed the key-value store proxy files, but removed them from the module and tests. I figured keeping them will help with the diff when we switch those to v2 instead. Not sure if this is the best strategy, but until we decide if we do a release or not without them, there's no pressure 😅

Also, I didn't remove the code for installing etcd and consul from the installer. Instead, I removed the --etcd and --consul flags from the CI and don't install them anymore, which I think it's fine atm.

One comment on this relating to the readthedocs failing. It's something to do with sphinx v4 removing PyClassmember. If you pull a new version of autodoc_traits.py, then it will build okay. I initially thought this was installed with pip, but then saw you've included a copy, in https://github.com/jupyterhub/traefik-proxy/tree/master/docs/sphinxext

Anyway, grab a new copy from here and the docs will build okay:-
https://github.com/jupyterhub/autodoc-traits/blob/main/autodoc_traits/autodoc_traits.py

Thanks for pointing this out ☀️ I removed the autodoc_traits copy from this repo and installed it via pip instead, similar with what's in jupyterhub.

Will try and figure out how to rebase my traefik-v2-file branch against this one later today.

I will leave this PR open for today too and self-merge tomorrow if nobody has any objections to it. Afterwards, I think it'd be safe to rebase your branch (the one with the cherry-picked commits from the big one) against the main traefik-v2 branch of this repo and go from there :)

Sounds good, thanks. I won't touch anything for now and will get back to it later in the week then.
KR, Alex

Thanks @alexleach! I'm going to merge this now 🎉

Just wanted to say I haven't forgotten or abandoned this, but have had to focus on some other projects for work the last couple of weeks. Hoping to get back to this next week though. Have a good weekend ☺️