From ebf999ed025a48b9481ee5d500c5da7e040551fa Mon Sep 17 00:00:00 2001
From: Min RK <benjaminrk@gmail.com>
Date: Fri, 19 Jan 2024 08:19:15 +0100
Subject: [PATCH] install redis on CI

separate each backend installation
---
 .github/workflows/test.yml   | 23 +++++++++++++++++++----
 performance/run_benchmark.sh |  2 +-
 2 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index a999231c..53f7a58e 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -32,7 +32,7 @@ env:
 jobs:
   # Run "pytest tests" for various Python versions
   pytest:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     timeout-minutes: 30
     strategy:
       # Keep running even if one variation of the job fail
@@ -45,6 +45,7 @@ jobs:
           - python: "3.9"
             backend: "consul"
           - python: "3.10"
+            backend: "redis"
           - python: "3.11"
     steps:
       # NOTE: In GitHub workflows, environment variables are set by writing
@@ -69,21 +70,35 @@ jobs:
           python -m jupyterhub_traefik_proxy.install --output=./bin
 
           pip freeze
-      - name: Install etcd, consul
+      - name: Install consul
+        if: matrix.backend == 'consul'
         run: |
           curl -L https://releases.hashicorp.com/consul/${CONSUL_VERSION}/consul_${CONSUL_VERSION}_linux_amd64.zip > consul.zip
           unzip consul.zip -d ./bin consul
+
+      - name: Install etcd
+        if: matrix.backend == 'etcd'
+        run: |
           curl -L https://github.com/etcd-io/etcd/releases/download/v${ETCD_DOWNLOAD_VERSION}/etcd-v${ETCD_DOWNLOAD_VERSION}-linux-amd64.tar.gz   > etcd.tar.gz
           tar -xzf etcd.tar.gz -C ./bin --strip-components=1 --wildcards '*/etcd*'
 
+      - name: Install redis
+        if: matrix.backend == 'redis'
+        # from https://redis.io/docs/install/install-redis/install-redis-on-linux/
+        run: |
+          curl -fsSL https://packages.redis.io/gpg | sudo gpg --dearmor -o /usr/share/keyrings/redis-archive-keyring.gpg
+          echo "deb [signed-by=/usr/share/keyrings/redis-archive-keyring.gpg] https://packages.redis.io/deb $(lsb_release -cs) main" | sudo tee /etc/apt/sources.list.d/redis.list
+          sudo apt-get -y update
+          sudo apt-get -y install redis
+
       - name: Select tests
         run: |
           if [[ ! -z "${{ matrix.backend }}" ]]; then
             # select backend subset
             echo "PYTEST_ADDOPTS=-k ${{ matrix.backend }}" >> "${GITHUB_ENV}"
           else
-            # default: select everything _but_ the etcd/consul backend tests
-            echo "PYTEST_ADDOPTS=-k 'not etcd and not consul'" >> "${GITHUB_ENV}"
+            # default: select everything _but_ the KV backend tests
+            echo "PYTEST_ADDOPTS=-k 'not etcd and not consul and not redis'" >> "${GITHUB_ENV}"
           fi
 
       - name: Run tests
diff --git a/performance/run_benchmark.sh b/performance/run_benchmark.sh
index 88130fcb..a0c96f84 100755
--- a/performance/run_benchmark.sh
+++ b/performance/run_benchmark.sh
@@ -16,7 +16,7 @@ for proxy in $proxies; do
     python3 -m performance.check_perf methods --proxy=$proxy --iterations=$iterations --concurrency=$concurrency --routes=$routes --output=./results/${proxy}-methods.csv
   done
 done
-
+exit 0
 
 # Throughput: