Only fix cell ID validation issues if asked #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 20, 2022 11:22
Adds a new kwarg to validate called `repair` which will fix well-known validation errors during the validation process, but only when set to `True`. Updates existing functionality to not mutate the notebook contents, but instead fail validation.
MSeal
reviewed
Jan 20, 2022
nbformat/validator.py
Outdated
| @@ -230,7 +230,7 @@ def better_validation_error(error, version, version_minor): | |||
|
|
|||
|
|
|||
| def validate(nbdict=None, ref=None, version=None, version_minor=None, | |||
| relax_add_props=False, nbjson=None): | |||
| relax_add_props=False, nbjson=None, repair=False): | |||
There was a problem hiding this comment.
Let's make it repair_dup_ids=True to be more specific and better match default behavior today
MSeal
reviewed
Jan 20, 2022
rgbkrk
reviewed
Jan 20, 2022
| @@ -258,8 +258,9 @@ def validate(nbdict=None, ref=None, version=None, version_minor=None, | |||
| if version is None: | |||
| version, version_minor = 1, 0 | |||
|
|
|||
| if ref is None and version >= 4 and version_minor >= 5: | |||
| # if we support cell ids ensure default ids are provided | |||
| notebook_supports_cell_ids = ref is None and version >= 4 and version_minor >= 5 | |||
rgbkrk
approved these changes
Jan 20, 2022
MSeal
reviewed
Jan 21, 2022
MSeal
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new kwarg to validate called
repairwhich will fix well-known validation errors during the validation process, but only when set toTrue.Updates existing functionality to not mutate the notebook contents, but instead fail validation.
See: #243, #235