Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct version python file? #101

Closed
echarles opened this issue May 20, 2022 · 2 comments · Fixed by #102
Closed

Correct version python file? #101

echarles opened this issue May 20, 2022 · 2 comments · Fixed by #102

Comments

@echarles
Copy link
Member

What is the best way to define the version for nbclassic, taking into account the jupyter_releaser process

For now, the check_release job is failing (see. https://github.com/jupyter/nbclassic/runs/6521439283?check_suite_focus=true) with

0.0.4
:: Bumping from 0.3.7 to 0.0.5
Error: nbclassic/__version__.py does not exist
Traceback (most recent call last):

Should we readd a __version__.py file that reexports the __version__ defined in _version.py. In that case, will the jupyter_releaser still be happy?

Any advice welcome here

cc/ @blink1073 @Zsailer

@blink1073
Copy link
Contributor

It should be nbclassic/_version.py in pyproject.toml. It is using a regex to read the version from the file.

@echarles
Copy link
Member Author

Thx @blink1073 I have opened #102 to fix the releaser ci job and it is now failing with error: [Errno 2] No such file or directory: 'pybabel' on https://github.com/jupyter/nbclassic/runs/6524838596?check_suite_focus=true#step:9:1284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants