-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the soft-deprecated endpoint #70
Milestone
Comments
@jtpio I have some notes that can help for older versions of nbreuse if you want to include in CHANGELOG. 01.0
0.2.0
0.3.0
0.3.1
This should reduce the number of /metrics requests massively, 0.3.2
0.3.3
0.3.4
|
Thanks a lot @Gsbreddy! Would you like to open a PR to create CHANGELOG.md with this content? Also we'll probably want to:
|
Sure thing. Let me do that and get back to you.
…On Fri, 20 Nov 2020 at 3:08 PM, Jeremy Tuloup ***@***.***> wrote:
Thanks a lot @Gsbreddy <https://github.com/Gsbreddy>!
Would you like to open a PR to create CHANGELOG.md with this content?
Also we'll probably want to:
- Sort in descending order
- Include 0.3.5 and 0.3.6 too
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB26ANN3HTIBARXRWDMV373SQY2HPANCNFSM4T3X737A>
.
|
Merged
Sure, I will add other versions by EOD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#68 switches the main endpoint to
/api/metrics/v1
, but keeps the original/metrics
under a flag.This should be documented, for example in a new CHANGELOG.md.
Also previous releases of JupyterLab 1.x and 2.x include a status bar item that requests metrics from the deprecated
/metrics
endpoint. It can be tricky to understand which versions of lab and nbresuse are compatible. However #69 should help with this in the long run.This is less problematic for classic notebook users since the frontend ships with
nbresuse
(#69 would do the same for the lab frontend)The text was updated successfully, but these errors were encountered: