Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High CPU consumption of PrometheusHandler #216

Open
mahendrapaipuri opened this issue Oct 4, 2023 · 1 comment
Open

High CPU consumption of PrometheusHandler #216

mahendrapaipuri opened this issue Oct 4, 2023 · 1 comment

Comments

@mahendrapaipuri
Copy link
Contributor

Problem

It seems like PrometheusHandler is consuming CPU even when there is no activity. More discussion in discourse thread.

We are setting up a PeriodicCallback for this handler which is eventually consuming that CPU. The not so clear part is that this handler is not registered with any endpoint for Prometheus to scrape the data. So, maybe this is vestigial piece of code?

Proposed Solution

If this PrometheusHandler is not critical, maybe we can set default config of enable_prometheus_metrics to False.

If PrometheusHandler is indeed unusable in the current state, we need to fix it for Prometheus to be able to scrap the metric data.

@welcome
Copy link

welcome bot commented Oct 4, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant