Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed of remote Jupyter out-of-band output resolves incorrectly #1670

Open
agoose77 opened this issue Nov 22, 2024 · 0 comments
Open

Embed of remote Jupyter out-of-band output resolves incorrectly #1670

agoose77 opened this issue Nov 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@agoose77
Copy link
Contributor

agoose77 commented Nov 22, 2024

Consider this deployment of a MyST site using Jupyter Notebooks:

https://agoose77.github.io/myst-notebook-demo/plot

As of writing, it publishes a plot:
Image

If we embed this into a local MyST server, MyST appears to re-write the embedded output.data.data."image/png".path to resolve against the local content server, which breaks the URL.

Image

From a cursory glance at our source code, I think we're rewriting all Output nodes, even if they're embedded. I don't have an immediate answer as to what to do here, it will take some thought about what embed means with respect to whether it should actually embed the AST or just pull in a placeholder. (I suspect there is an obvious clear answer of the former)

@agoose77 agoose77 added the bug Something isn't working label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant