Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should peer dependency break existing functionlaity of spl-token deps? #130

Open
ComradePashka opened this issue Nov 23, 2024 · 0 comments

Comments

@ComradePashka
Copy link

Hello!

I am using latest spl-token library (0.4.9) in my web3 app and when I add Jupiter Widget as npm package all imports for @solana/spl-token are pointing to Jupiter dependency(0.1.8) so all new features are not available.

if I install @solana/spl-token as alias and import aliased version, e.g.

yarn add @solana/spl-token-latest@npm:@solana/[email protected]

...

import { getMetadataPointerState, getMint, getTokenMetadata, TOKEN_2022_PROGRAM_ID, TOKEN_PROGRAM_ID } from '@solana/spl-token-latest'

-- all functionality is working as expected not conflicting with Jupiter deps.

yarn list @solana/spl-token                                  
yarn list v1.22.22
warning Filtering by arguments is deprecated. Please use the pattern option instead.
├─ @jup-ag/[email protected]
│  ├─ @metaplex-foundation/[email protected]
│  │  └─ @solana/[email protected]
│  └─ @solana/[email protected]
├─ @jup-ag/[email protected]
│  └─ @solana/[email protected]
├─ @jup-ag/[email protected]
│  └─ @solana/[email protected]
├─ @mercurial-finance/[email protected]
│  └─ @solana/[email protected]
└─ @solana/[email protected]
✨  Done in 0.40s.

Was it designed so? Is there any other solution to not break existing spl-token root dependency for entire project?

thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant