Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bridges] Add MOI.Bridge.FirstBridge attribute #2211

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Conversation

blegat
Copy link
Member

@blegat blegat commented Jun 20, 2023

I find this useful when debugging. Getting the second bridge doesn't make much sense since the first bridge might create several constraints.

@odow
Copy link
Member

odow commented Sep 6, 2023

What's the status of this? I don't know if we need this in MOI

@blegat
Copy link
Member Author

blegat commented Sep 13, 2023

This is often useful for debugging but I was waiting for feedback before continuing

@odow
Copy link
Member

odow commented Sep 13, 2023

Is it useful though? For debugging it seems like you could just use the various .model etc.

@blegat
Copy link
Member Author

blegat commented Sep 14, 2023

Is it useful though? For debugging it seems like you could just use the various .model etc.

Yes, but it's always a bit hacky, takes time and depends on how many layers and so on. So you can't use in a tutorial for instance.

@odow
Copy link
Member

odow commented Sep 14, 2023

Why would we want to use this in a tutorial? How exactly does it help debugging?

@odow
Copy link
Member

odow commented Nov 3, 2023

What do you want to do with this? Shall I fix the test and add? Or shall we close?

@odow odow marked this pull request as ready for review November 6, 2023 01:30
@odow odow changed the title Add FirstBridge [Bridges] Add MOI.Bridge.FirstBridge attribute Nov 6, 2023
src/Utilities/functions.jl Outdated Show resolved Hide resolved
@odow
Copy link
Member

odow commented Nov 12, 2023

@blegat merge or close?

@blegat blegat merged commit 460cad7 into master Nov 14, 2023
16 of 17 checks passed
@blegat blegat deleted the bl/first_bridge branch November 14, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants