Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for older drivers #482

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve support for older drivers #482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/main/java/sqlline/BufferedRows.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,17 @@ private List<Row> nextList() throws SQLException {
list.add(columnTypes);
}
}
if (rs.isClosed()) {

// For drivers compiled with earlier versions of Java
// The ResultSet isClosed method may be unsupported
boolean resultSetClosed = false;
try {
resultSetClosed = rs.isClosed();
} catch (AbstractMethodError e) {
sqlLine.debug("ResultSet isClosed() not suported by driver");
}

if (resultSetClosed) {
// Result set is closed. Perhaps the driver closed it automatically
// because we reached the end. Do nothing.
} else if (limit > 0) {
Expand Down