Fix text wrapping, links #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2019
|
Hey, thanks for the PR and apologies for my inactivity. Currently I personally have no use for this library so responding to these has been duly slow. I would fully support you doing a rewrite of the library, and can happily transfer the npm package ownership to you. Hit me up via email at [email protected] if you're interested in taking over :) |
|
Sounds great @lappalj4, just sent you an email. |
|
I've released these fixes on the new app version which we now maintain Also installable with npm under this same package name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been working with this library for a couple weeks, and needed to fix a couple regressions that appeared in
1.2.0.This brings back
Utils.isTextOnlywhich was needed to get proper inline text wrapping.1.20.0had a regression where text only blocks, e.g.:Would render like:
This is a text block
with bold
items that would wrap to three lines
It now properly checks when rendering certain components, and if all children are of type Text, our wrapper should also be text.
I also removed the need for static class properties as it unnecessarily requires build tools that should not be required. I have a babel build version of this module, and plan on doing a rewrite in the future with typescript if there is any interest from the maintainer and/or community.
I believe this should fix #15, fix #18, fix #20