Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does this convert to lowercase? #14

Open
9mm opened this issue Nov 2, 2016 · 1 comment
Open

Why does this convert to lowercase? #14

9mm opened this issue Nov 2, 2016 · 1 comment

Comments

@9mm
Copy link

9mm commented Nov 2, 2016

I just lost so much time because it seems either this library, or my partners php base62 library is behaving very unexpectedly.

This one converts 10008287 to fzbz and his converts it to FZBZ.

I checked another base62 gem for sanity... this one: https://github.com/steventen/base62-rb

And it also does it as FZBZ. Every other library I've tried thus far uses uppercase.

Do you know why this is? I thought there was only 1 kind of base62, without any room for variation?

@ysllyfe
Copy link

ysllyfe commented Sep 4, 2017

@9mm the PRIMITIVES key sequence in this gem is 0-9 A-Z a-z, base62-rb is 0-9 a-z A-Z, you can choose or modify it yourself
Still not yet a standard CharacterSet for the Base62.
But the "A" ASCII is less than "a", so i think 0-9 A-Z a-z is more Suitable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants