-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
could ssh-audit print desired config or add Generic guide documentation #191
Comments
This would require ssh-audit to be able to precisely identify the server's precise OpenSSH version. This isn't as easy as it sounds, as some distros back-port changes without bumping version numbers.
I'm not sure what you mean here. The guides are very specific to each OS/platform otherwise the commands would fail.
Sounds like this is a failure related to your RSA host keys. This would be fixed by re-generating them using |
@jtesta
What I mean with a generic guide is that I have / had some older hosts where I compile openssh from source and replace the default package. When I apply the guide matching the OS (like Centos 7) I don't get a flawless audit but what you mentioned last, about regenerating the rsa key. Now that makes sense as I could not do that step for the host in question without reaching out to external parties connecting to the server first. |
Ahh, I see what you mean. Sure, that would be pretty straightforward to add, but that would also increase my ongoing maintenance costs. I already feel like I'm always slightly behind, so perhaps this won't get implemented for the time being. However, if enough people want this feature, I'll certainly reconsider. Feel free to vote on this issue by adding a thumbs-up emoji to this comment. |
hello @jtesta , @daniejstriata I have a draft implementation that prints out Server and Client configuration guides taken from Joes's website : https://www.ssh-audit.com/hardening_guides.html The code is in a new branch here : https://github.com/oam7575/ssh-audit/tree/print_harden_guide I will not create a pull request for this branch until such time as the argparse changes are merged as any clean up work for PR #304 will likely have flow on effects for this branch. Notes: I can appreciate that this may need to be adjusted if / when the time comes. Example 1: Result:
Example 2: Result:
Example 3: Result:
|
@daniejstriata @jtesta PR #307
Usage as per my previous comments - with out quotes
Result:
There is a whole lot of raw print statements : Eg print(r"some string with a ") : due to lots of double-quote, single-quote and slashes ( / \ ) in the strings. I have run tox several times and made best effort to ensure correctness - however I have been known to make mistakes. |
A simple bash script to run the commands "auto magically" for all iterations and "known bad values" This will print everything directly to console, along with a whole host of "this is not a valid server"
|
Can
ssh-audit
not print out the desired sshd config as an option or will it be possible to add a generic section to the guides? There are no guides for RHEL 9 based distros yet. I have some items I'm unsure how to resolve. Like:I have updated my moduli from the commands given in the hardening guide.
The text was updated successfully, but these errors were encountered: