Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since 21-Jul-2021 your package does not work in Chrome #36

Open
damilaufer opened this issue Jul 26, 2021 · 6 comments
Open

Since 21-Jul-2021 your package does not work in Chrome #36

damilaufer opened this issue Jul 26, 2021 · 6 comments

Comments

@damilaufer
Copy link

Since version 92 of Chrome, SharedArraybuffer needs a special cross-origin setting. Without it, you get the error below.
Maybe you can drop the usage of webidl-conversions. They say you should not use it, even in THEIR readme.md

bundle.js:10825 Uncaught ReferenceError: SharedArrayBuffer is not defined
at Object.../node_modules/notebookjs/node_modules/webidl-conversions/lib/index.js (bundle.js:10825)
at i (bundle.js:1)
at Object.../node_modules/notebookjs/node_modules/whatwg-url/dist/URL.js (bundle.js:10843)
at i (bundle.js:1)
at Object.../node_modules/notebookjs/node_modules/whatwg-url/webidl2js-wrapper.js (bundle.js:10903)
at i (bundle.js:1)
at Object.../node_modules/notebookjs/node_modules/whatwg-url/index.js (bundle.js:10897)
at i (bundle.js:1)
at Object. (bundle.js:7663)
at Object.../node_modules/notebookjs/node_modules/jsdom/lib/api.js (bundle.js:7663)

@manjunathangv
Copy link

manjunathangv commented Jul 27, 2021

I am also facing the same issue. @damilaufer any update or found way? Please post here!

@victorzxj
Copy link

I also facing the same issue in Chrome 92.

@jsvine
Copy link
Owner

jsvine commented Aug 11, 2021

Hmmmm, the error seems to be stemming fromwebidl-conversions, which is imported by jsdom — but jsdom isn't needed for notebookjs's browser-based rendering (only Node/CLI-based rendering). And https://jsvine.github.io/nbpreview/, which uses notebookjs without importing jsdom, seems to be working fine in Chrome 92. What is your specific setup?

@damilaufer
Copy link
Author

damilaufer commented Aug 11, 2021 via email

@jsvine
Copy link
Owner

jsvine commented Aug 11, 2021

@damilaufer Thanks. I don't use React, so I'm not familiar with how it handles dependencies. Perhaps someone more familiar with React can help debug and suggest changes that would resolve this use-case?

@victorzxj
Copy link

victorzxj commented Aug 12, 2021

@damilaufer Thanks. I don't use React, so I'm not familiar with how it handles dependencies. Perhaps someone more familiar with React can help debug and suggest changes that would resolve this use-case?

yeah~ I try to remove the jsdom dependence In my React project, and it works. Then i push the new npm package to private npm library for team use.thanks for your suggestion.

mapmeld added a commit to mapmeld/notebookjs that referenced this issue Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants