Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying RSpec command line options #34

Open
brynary opened this issue Jan 30, 2012 · 3 comments
Open

Allow specifying RSpec command line options #34

brynary opened this issue Jan 30, 2012 · 3 comments

Comments

@brynary
Copy link
Contributor

brynary commented Jan 30, 2012

Spin will ignore any arguments passed to spin serve that are not paths to files:

spin/bin/spin

Line 191 in 72fbfc6

f = files_to_load.select { |f| File.exist?(f.split(':')[0].to_s) }.uniq.join(SEPARATOR)

This is unfortunate, as it prevents passing RSpec options to spin serve. I propose spin support a way to send in ARGV options that get set as the ARGV in the forked process.

Maybe we could use this style:

spin push -- --color --profile --tag type:model

Thoughts?

@jstorimer
Copy link
Owner

Makes sense to me. I like it.

@andhapp
Copy link

andhapp commented Mar 19, 2012

Is specifying rspec options in .rspec file and letting spin pick it up from there not the best option? or are you suggesting that spin should support both.

@rosic
Copy link
Contributor

rosic commented Jun 25, 2012

I've cleaned up the bits for test unit from PR #45 to support this syntax with Rspec as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants