Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Copy button overlaps with content #791

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

third
Copy link

@third third commented Oct 28, 2024

Proposed fix for #782

  • Added right padding
  • Handled overflowing text when scrolling to the right

Screenshot 2024-10-27 at 9 27 39 PM

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2024

CLA assistant check
All committers have signed the CLA.

@third third marked this pull request as ready for review October 28, 2024 02:15
@third
Copy link
Author

third commented Oct 30, 2024

#790 is also covered by this fix.

@crowlKats
Copy link
Collaborator

@third this is not working on firefox for me; works on chrome though.

@third
Copy link
Author

third commented Nov 2, 2024

@third this is not working on firefox for me; works on chrome though.

@crowlKats I updated the code to fix Firefox issue. Let me know how it works on your end.

@crowlKats
Copy link
Collaborator

seems the import statement is collapsed now:

Screenshot 2024-11-06 at 00 01 11

@third
Copy link
Author

third commented Nov 6, 2024

@crowlKats Good eye. Here's my latest fix and screenshots. Tested in Chrome, Firefox and Safari.

Screenshot 2024-11-05 at 8 17 16 PM

Hovered version
Screenshot 2024-11-05 at 8 17 58 PM

@lucacasonato
Copy link
Member

When you triple click on any of the words in the import statement, only that word is now selected. Previously the entire statement was selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants