Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ban cjs & cts file extensions #713

Open
dsherret opened this issue Sep 5, 2024 · 2 comments · May be fixed by #818
Open

Ban cjs & cts file extensions #713

dsherret opened this issue Sep 5, 2024 · 2 comments · May be fixed by #818
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dsherret
Copy link
Member

dsherret commented Sep 5, 2024

These should be banned as they don't work.
@github-project-automation github-project-automation bot moved this to Needs Triage in JSR Sep 5, 2024
@lucacasonato lucacasonato added bug Something isn't working good first issue Good for newcomers labels Oct 28, 2024
@mbhrznr
Copy link
Contributor

mbhrznr commented Oct 31, 2024

how would such banning look like?
i'd assume it could be a thrown error during publish/dry run?

i'd love to give it a spin, as it might be a nice opportunity to check the inner workings of jsr.

@crowlKats
Copy link
Collaborator

i'd assume it could be a thrown error during publish/dry run?

correct; and i think then on JSR's backend we should handle it as well in case

@mbhrznr mbhrznr linked a pull request Nov 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
JSR
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ban cjs and cts file extensions mbhrznr/jsr
4 participants
@dsherret @lucacasonato @mbhrznr @crowlKats