v8 update #144
Open
v8 update #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f02d18e The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jodeleeuw
requested changes
Oct 21, 2024
packages/plugin-audio-multi-response/docs/jspsych-audio-multi-response.md
Outdated
Show resolved
Hide resolved
jodeleeuw
requested changes
Nov 30, 2024
| @@ -1,9 +1,9 @@ | |||
| <!DOCTYPE html> | |||
| <html> | |||
| <head> | |||
| <script src="https://unpkg.com/jspsych@7.3.2"></script> | |||
| <script src="https://unpkg.com/jspsych@8.0.2"></script> | |||
There was a problem hiding this comment.
Is this the desired version? 8.0.2?
There was a problem hiding this comment.
it was the most recent version at the time of writing; though we could get around this by simply doing <script src="https://unpkg.com/jspsych@8"></script> to always query the latest version?
| <script src="../dist/index.browser.js"></script> | ||
| <link rel="stylesheet" href="https://unpkg.com/jspsych@7.3.2/css/jspsych.css" /> | ||
| <link rel="stylesheet" href="https://unpkg.com/jspsych@8.0.2/css/jspsych.css" /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR closes #138, focusing broadly on updating most (self paced reading is being completely reworked) plugins to jspsych v8, which necessitates breaking changes for all plugins as certain features handled by the core package like clearing timers/displays are left to the core package itself, along with certain plugins such as the audio plugins and plugins with
button_html-esque fields being updated.in order to improve developer experience, some plugins have added documentation where it was missing beforehand.
while all plugins function in v8, to move this PR off of draft and into merge consideration, there are several final passes and one blocking issue to content with:
ParameterType.COMPLEXdata types, specifically listing and documenting nested variablespackage.jsonversioning to plugin info versioning