Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require dependencies build issues with version 5.0.0 #318

Closed
dapriett opened this issue Jul 29, 2015 · 4 comments
Closed

require dependencies build issues with version 5.0.0 #318

dapriett opened this issue Jul 29, 2015 · 4 comments

Comments

@dapriett
Copy link

I tried upgrading from version 4.8.0 to 5.0.0. Now in my application JS file when I add requires //= require dependency, it's causing both a <script> tag to be created, as well as concating it to my application js. I'm running in dev mode, so it should only add the <script> tags. I reverted back to 4.8.0 and now I'm fine.

@dapriett dapriett changed the title Require Build issues with verson 5.0.0 require dependencies build issues with version 5.0.0 Jul 29, 2015
@adunkman
Copy link
Collaborator

Interesting! Thanks for the issue report @dapriett.

/cc @blakevanlan in case you saw something similar in #315.

@blakevanlan
Copy link
Collaborator

I didn't see this when I was adding source maps but I was able to reproduce the issue. I'll give it a look and see what's going on.

@adunkman
Copy link
Collaborator

adunkman commented Aug 1, 2015

Published as v5.0.1. Thanks for reporting the bug, @dapriett! It’s now covered by this test, thanks to @blakevanlan!

@dapriett
Copy link
Author

dapriett commented Aug 3, 2015

Thanks for the fix @adunkman! Just tested it, works good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants