From 879ffc0e5959fb4a87ffeca32a8284d658fee6b5 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Sun, 1 Dec 2024 00:03:45 +0100 Subject: [PATCH] Try this --- scripts/BuildRequirementsCheckMatrix.php | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/scripts/BuildRequirementsCheckMatrix.php b/scripts/BuildRequirementsCheckMatrix.php index 59bd2672b3..3f95a96f96 100644 --- a/scripts/BuildRequirementsCheckMatrix.php +++ b/scripts/BuildRequirementsCheckMatrix.php @@ -152,7 +152,7 @@ private function getMissingExtensionsBuilds() 'missing tokenizer' => 'none, xmlwriter, SimpleXML', 'missing xmlwriter' => ':xmlwriter', 'missing SimpleXML' => ':SimpleXML', - 'missing both XML exts' => ':xmlwriter, :SimpleXML', + 'missing both XML exts' => 'none, tokenizer', ]; $builds = []; @@ -160,6 +160,13 @@ private function getMissingExtensionsBuilds() foreach ($this->cmd as $cmd) { foreach ($extensions as $name => $exts) { foreach ($this->os as $os) { + // Skip the extension requirements check on Windows as the required extensions cannot be + // disabled on Windows. They are compiled statically into the PHP binary. + // Ref: https://github.com/shivammathur/setup-php/issues/887 + if ($os === 'windows-latest') { + continue; + } + $builds[] = [ 'name' => "❌ $name", 'os' => $os,