Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http://flowplayer.org/tools/demos/scrollable/navigation.html - is this still required? #28

Open
alibby251 opened this issue Oct 23, 2011 · 7 comments

Comments

@alibby251
Copy link
Contributor

I've come across this page as part of troubleshooting an issue - I'm not sure it is still valid?

@phloxic
Copy link
Contributor

phloxic commented Oct 24, 2011

It's not needed because it's broken :-(
Try:
http://flowplayer.org/tools/scrollable/index.html#plugins
It should go to the plugins item, but it doesn't. Hash navigation is broken by:
a69f655e537bab8cadb33000021b6daaadf084c4

@bradrobertson
Copy link
Contributor

that commit link gives a 404, can you point me in the right direction and i'll get it fixed up?

@phloxic
Copy link
Contributor

phloxic commented Nov 1, 2011

This is not a fix, and jquerytools are the culprit, trying full link:
jquerytools/jquerytools@a69f655
The changes to tools.navigator.js break hash navigation.
I was successful for some setups by just backing out the changes to navigator while leaving everything else at the most recent state. But I am not sure whether it breaks other stuff.
Tero seems to want to abolish navigator - by breaking it ;-)
Hash navigation can be scripted without navigator on your own, but then it should not be advertised - or used on the jquerytools pages themselves. And the non-backwards compatible change should be announced.

@bradrobertson
Copy link
Contributor

ya I noticed that he's using pushState now and does not adjust the href at all in the process. This definitely removes the old hashchange behavior. I could possibly implement something similar using pushState and hashes, though pushState is only supported by modern browsers.

I wonder how many people want this to work for IE < 9 ? In its current state, I can't see that it would.

@phloxic
Copy link
Contributor

phloxic commented Nov 1, 2011

Isn't push state about history?
Changes wrt history should not break existing navigation functionality - hash navi worked also in IE before, only history: true had no effect I guess.

@bradrobertson
Copy link
Contributor

ya pushState is the newer implementation of using hash changes. So yes it's all about history, it's just a more robust implementation that allows you to adjust the window.location without using hashes and without doing a refresh. Problem is, it's not adjusting the url right now in the navigator plugin, so even though forward/back buttons work, if you refreshed, you'd just get the root element.

I'm wondering though what the current state of navigation is in IE since Tero made that change. I don't have easy access to a PC, are you able to check IE7 or IE8 with the scrollable navigator and see what you get?

@alibby251
Copy link
Contributor Author

From what I know, based on emails from Tero - Tero is looking to drop the Toolbox part of Tools, as I don't think it sits very well architecturally, within the Tools toolset. This would affect History, which I think he is replacing with pushState. I think there may be elements of functionality within this part of Tools that will be superseded by newer, more reliable functionality in version 2, so whilst Toolbox will go, the more useful elements will remain, but as part of other tools in the library.

As far as I know, pushState is very much HTML5, so I'm not sure if or how it would work in IE, in browsers lower than IE9? I'm happy to help test as well if you need it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants